fix: improve logs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example output before my change:
```
Retrieval failed with status code 502: no candidates found
{
timeout: false,
startAt: 2024-05-31T07:30:43.389Z,
// etc.
protocol: "graphsync",
providerAddress: "/ip4/118.212.68.22/tcp/24501/p2p/12D3KooWJJEL214g7yMFMFaE6aPRaQTLVVCNFjWeiBLUCTzP98tp"
}
Submitting measurement...
{
sparkVersion: "1.11.4",
zinniaVersion: "0.19.1",
cid: "bafykbzacechhbxnsn5dw6lx7phcfvkjc6kqsuuwl4bnynexewb5y3vtcw2fvw",
minerId: "f02894875",
timeout: false,
startAt: 2024-05-31T07:30:43.389Z,
// etc.
providerAddress: "/ip4/118.212.68.22/tcp/24501/p2p/12D3KooWJJEL214g7yMFMFaE6aPRaQTLVVCNFjWeiBLUCTzP98tp",
participantAddress: "0x000000000000000000000000000000000000dEaD",
stationId: "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
}
```
This commit removes the first log which was printed when `fetch()`
was able to get some HTTP response frome the server.
It is also removing the trailing newline from HTTP error response bodies
before we print them to the console.
Finally, it adds an empty line between tasks, to visually delimit
logs belonging to different tasks.
|
@juliangruber feel free to land & release this change yourself, if you have time & appetite. |
juliangruber
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output before my change:
This commit removes the first log which was printed when
fetch()was able to get some HTTP response frome the server.It is also removing the trailing newline from HTTP error response bodies before we print them to the console.
Finally, it adds an empty line between tasks, to visually delimit logs belonging to different tasks.